end{pw,sp}ent() can only be called after get{pw,sp}ent()

Calling them unconditionally can result in memory corruption.

diff --git a/slock.c b/slock.c
index 399386bd31fc3f16bb39bc59e556e72d72c9ee28..d281965809db3017767aa5f12cbd99dd31c97482 100644 (file)
--- a/slock.c
+++ b/slock.c
@@ -73,7 +73,6 @@ getpw(void) { /* only run as root */
                else
                        die("slock: cannot retrieve password entry (make sure to suid or sgid slock)\n");
        }
-       endpwent();
        rval =  pw->pw_passwd;
 
 #if HAVE_SHADOW_H
@@ -82,7 +81,6 @@ getpw(void) { /* only run as root */
                sp = getspnam(getenv("USER"));
                if(!sp)
                        die("slock: cannot retrieve shadow entry (make sure to suid or sgid slock)\n");
-               endspent();
                rval = sp->sp_pwdp;
        }
 #endif