Improve speed of drw_text when provided with large strings
authorMiles Alan <m@milesalan.com>
Mon, 9 Aug 2021 16:24:14 +0000 (18:24 +0200)
committerHiltjo Posthuma <hiltjo@codemadness.org>
Mon, 9 Aug 2021 16:25:19 +0000 (18:25 +0200)
Calculates len & ew in drw_font_getexts loop by incrementing instead of
decrementing; as such avoids proportional increase in time spent in loop
based on provided strings size.

drw.c

diff --git a/drw.c b/drw.c
index 4cdbcbe51c2945f1f9be817e910f0331e1f1ea64..9c3908646eb39e36ac5f03defe0b03653446d85a 100644 (file)
--- a/drw.c
+++ b/drw.c
@@ -310,8 +310,11 @@ drw_text(Drw *drw, int x, int y, unsigned int w, unsigned int h, unsigned int lp
                if (utf8strlen) {
                        drw_font_getexts(usedfont, utf8str, utf8strlen, &ew, NULL);
                        /* shorten text if necessary */
-                       for (len = MIN(utf8strlen, sizeof(buf) - 1); len && ew > w; len--)
-                               drw_font_getexts(usedfont, utf8str, len, &ew, NULL);
+                       if (ew > w)
+                               for (ew = 0, len = 0; ew < w - lpad * 2 && len < MIN(utf8strlen, sizeof(buf) - 1); len++)
+                                       drw_font_getexts(usedfont, utf8str, len, &ew, NULL);
+                       else
+                               len = MIN(utf8strlen, sizeof(buf) - 1);
 
                        if (len) {
                                memcpy(buf, utf8str, len);