Revert "Improve speed of drw_text when provided with large strings"
authorHiltjo Posthuma <hiltjo@codemadness.org>
Fri, 20 Aug 2021 21:05:53 +0000 (23:05 +0200)
committerHiltjo Posthuma <hiltjo@codemadness.org>
Fri, 20 Aug 2021 21:05:53 +0000 (23:05 +0200)
This reverts commit c585e8e498ec6f9c423ab8ea07cf853ee5b05fbe.

It causes issues with truncation of characters when the text does not fit and
so on.  The patch should be reworked and properly tested.

drw.c

diff --git a/drw.c b/drw.c
index 9c3908646eb39e36ac5f03defe0b03653446d85a..4cdbcbe51c2945f1f9be817e910f0331e1f1ea64 100644 (file)
--- a/drw.c
+++ b/drw.c
@@ -310,11 +310,8 @@ drw_text(Drw *drw, int x, int y, unsigned int w, unsigned int h, unsigned int lp
                if (utf8strlen) {
                        drw_font_getexts(usedfont, utf8str, utf8strlen, &ew, NULL);
                        /* shorten text if necessary */
-                       if (ew > w)
-                               for (ew = 0, len = 0; ew < w - lpad * 2 && len < MIN(utf8strlen, sizeof(buf) - 1); len++)
-                                       drw_font_getexts(usedfont, utf8str, len, &ew, NULL);
-                       else
-                               len = MIN(utf8strlen, sizeof(buf) - 1);
+                       for (len = MIN(utf8strlen, sizeof(buf) - 1); len && ew > w; len--)
+                               drw_font_getexts(usedfont, utf8str, len, &ew, NULL);
 
                        if (len) {
                                memcpy(buf, utf8str, len);