Format error messages properly

Make use of strerror(errno) and format all errors equally:
function ['parameters']: error message

diff --git a/components/battery.c b/components/battery.c
index cd1169ddb0509a523cc4386d6154d9e9673cb0a5..75f29456105ab264825d89ec4402e4ac5f86b751 100644 (file)
--- a/components/battery.c
+++ b/components/battery.c
@@ -1,5 +1,7 @@
 /* See LICENSE file for copyright and license details. */
+#include <errno.h>
 #include <stdio.h>
+#include <string.h>
 #if defined(__linux__)
 #include <limits.h>
 #include <string.h>
@@ -28,12 +30,12 @@ battery_perc(const char *bat)
 
        fd = open("/dev/apm", O_RDONLY);
        if (fd < 0) {
-               fprintf(stderr, "Failed to open file /dev/apm");
+               fprintf(stderr, "open '/dev/apm': %s\n", strerror(errno));
                return NULL;
        }
 
        if (ioctl(fd, APM_IOC_GETPOWER, &apm_info) < 0) {
-               fprintf(stderr, "Failed to get battery info");
+               fprintf(stderr, "ioctl 'APM_IOC_GETPOWER': %s\n", strerror(errno));
                close(fd);
                return NULL;
        }

diff --git a/components/disk.c b/components/disk.c
index 3d8140e64e9cb1c51169aef0fec82be9b528c6dc..8a9caa127713fb5bd8db7b9361de8947904cb430 100644 (file)
--- a/components/disk.c
+++ b/components/disk.c
@@ -1,5 +1,7 @@
 /* See LICENSE file for copyright and license details. */
+#include <errno.h>
 #include <stdio.h>
+#include <string.h>
 #include <sys/statvfs.h>
 
 #include "../util.h"
@@ -10,7 +12,7 @@ disk_free(const char *mnt)
        struct statvfs fs;
 
        if (statvfs(mnt, &fs) < 0) {
-               fprintf(stderr, "Failed to get filesystem info");
+               fprintf(stderr, "statvfs '%s': %s\n", mnt, strerror(errno));
                return NULL;
        }
 
@@ -24,7 +26,7 @@ disk_perc(const char *mnt)
        struct statvfs fs;
 
        if (statvfs(mnt, &fs) < 0) {
-               fprintf(stderr, "Failed to get filesystem info");
+               fprintf(stderr, "statvfs '%s': %s\n", mnt, strerror(errno));
                return NULL;
        }
 
@@ -39,7 +41,7 @@ disk_total(const char *mnt)
        struct statvfs fs;
 
        if (statvfs(mnt, &fs) < 0) {
-               fprintf(stderr, "Failed to get filesystem info");
+               fprintf(stderr, "statvfs '%s': %s\n", mnt, strerror(errno));
                return NULL;
        }
 
@@ -52,7 +54,7 @@ disk_used(const char *mnt)
        struct statvfs fs;
 
        if (statvfs(mnt, &fs) < 0) {
-               fprintf(stderr, "Failed to get filesystem info");
+               fprintf(stderr, "statvfs '%s': %s\n", mnt, strerror(errno));
                return NULL;
        }
 

diff --git a/components/hostname.c b/components/hostname.c
index 45dbb5bcb0a3bb97e39c6d0bee9fcfe5109aec52..d7c10c871db99d8554cb65f7563713efcfa9a547 100644 (file)
--- a/components/hostname.c
+++ b/components/hostname.c
@@ -1,5 +1,7 @@
 /* See LICENSE file for copyright and license details. */
+#include <errno.h>
 #include <stdio.h>
+#include <string.h>
 #include <unistd.h>
 
 #include "../util.h"
@@ -8,7 +10,7 @@ const char *
 hostname(void)
 {
        if (gethostname(buf, sizeof(buf)) == -1) {
-               fprintf(stderr, "gethostbyname failed");
+               fprintf(stderr, "gethostbyname: %s\n", strerror(errno));
                return NULL;
        }
 

diff --git a/components/ip.c b/components/ip.c
index c46ec9e685a4c09b78a28fe671dac7befb81fbe1..686344b701175f66d94c6e0510a497b1ad14472f 100644 (file)
--- a/components/ip.c
+++ b/components/ip.c
@@ -1,5 +1,6 @@
 /* See LICENSE file for copyright and license details. */
 #if defined(__linux__)
+#include <errno.h>
 #include <ifaddrs.h>
 #include <netdb.h>
 #include <stdio.h>
@@ -15,7 +16,7 @@ ipv4(const char *iface)
        char host[NI_MAXHOST];
 
        if (getifaddrs(&ifaddr) == -1) {
-               fprintf(stderr, "Failed to get IPv4 address for interface %s", iface);
+               fprintf(stderr, "getifaddrs: %s\n", strerror(errno));
                return NULL;
        }
 
@@ -26,7 +27,7 @@ ipv4(const char *iface)
                s = getnameinfo(ifa->ifa_addr, sizeof(struct sockaddr_in), host, NI_MAXHOST, NULL, 0, NI_NUMERICHOST);
                if ((strcmp(ifa->ifa_name, iface) == 0) && (ifa->ifa_addr->sa_family == AF_INET)) {
                        if (s != 0) {
-                               fprintf(stderr, "Failed to get IPv4 address for interface %s", iface);
+                               fprintf(stderr, "getnameinfo: %s\n", gai_strerror(s));
                                return NULL;
                        }
                        return bprintf("%s", host);
@@ -46,7 +47,7 @@ ipv6(const char *iface)
        char host[NI_MAXHOST];
 
        if (getifaddrs(&ifaddr) == -1) {
-               fprintf(stderr, "Failed to get IPv6 address for interface %s", iface);
+               fprintf(stderr, "getifaddrs: %s\n", strerror(errno));
                return NULL;
        }
 
@@ -57,7 +58,7 @@ ipv6(const char *iface)
                s = getnameinfo(ifa->ifa_addr, sizeof(struct sockaddr_in6), host, NI_MAXHOST, NULL, 0, NI_NUMERICHOST);
                if ((strcmp(ifa->ifa_name, iface) == 0) && (ifa->ifa_addr->sa_family == AF_INET6)) {
                        if (s != 0) {
-                               fprintf(stderr, "Failed to get IPv6 address for interface %s", iface);
+                               fprintf(stderr, "getnameinfo: %s\n", gai_strerror(s));
                                return NULL;
                        }
                        return bprintf("%s", host);

diff --git a/components/kernel_release.c b/components/kernel_release.c
index f539b6a2e6b7bd34224b4ef6794fb84ec06bee19..4e67a28509a1ad0a00a4ded819e8f731fd581ba1 100644 (file)
--- a/components/kernel_release.c
+++ b/components/kernel_release.c
@@ -1,6 +1,8 @@
 /* See LICENSE file for copyright and license details. */
+#include <errno.h>
 #include <sys/utsname.h>
 #include <stdio.h>
+#include <string.h>
 
 #include "../util.h"
 
@@ -10,6 +12,7 @@ kernel_release(void)
        struct utsname udata;
 
        if (uname(&udata) < 0) {
+               fprintf(stderr, "uname: %s\n", strerror(errno));
                return NULL;
        }
 

diff --git a/components/keyboard_indicators.c b/components/keyboard_indicators.c
index 47b52c66a4695f0262b584d31ab9cd63e00f1342..76cf17e54e4411a9cc83918840505e34422ddfdd 100644 (file)
--- a/components/keyboard_indicators.c
+++ b/components/keyboard_indicators.c
@@ -11,7 +11,7 @@ keyboard_indicators(void)
        XKeyboardState state;
 
        if (dpy == NULL) {
-               fprintf(stderr, "Cannot open display");
+               fprintf(stderr, "Cannot open display\n");
                return NULL;
        }
        XGetKeyboardControl(dpy, &state);

diff --git a/components/load_avg.c b/components/load_avg.c
index 5e1571d11c73d160b4aee2e03e1a988bf2d6a760..526dc7137456b7d778f529b63e200b9c5126017a 100644 (file)
--- a/components/load_avg.c
+++ b/components/load_avg.c
@@ -10,7 +10,7 @@ load_avg(const char *fmt)
        double avgs[3];
 
        if (getloadavg(avgs, 3) < 0) {
-               fprintf(stderr, "Failed to get the load avg");
+               fprintf(stderr, "getloadavg: Could not obtain load average.\n");
                return NULL;
        }
 

diff --git a/components/num_files.c b/components/num_files.c
index c471400d8a3aff3ae58e2e8459ae9b6f8be49c2a..acf9dfa0a2b1a32f49efea9070ac185aaf4a1b72 100644 (file)
--- a/components/num_files.c
+++ b/components/num_files.c
@@ -1,4 +1,5 @@
 /* See LICENSE file for copyright and license details. */
+#include <errno.h>
 #include <dirent.h>
 #include <stdio.h>
 #include <string.h>
@@ -13,7 +14,7 @@ num_files(const char *dir)
        int num = 0;
 
        if ((fd = opendir(dir)) == NULL) {
-               fprintf(stderr, "Failed to get number of files in directory %s", dir);
+               fprintf(stderr, "opendir '%s': %s\n", dir, strerror(errno));
                return NULL;
        }
 

diff --git a/components/run_command.c b/components/run_command.c
index 4a6389620fdd8ca8169e0bc03f92b74f1e0f669b..2041ae4aa1c9712a8f009bc1cf79b8d55d29a106 100644 (file)
--- a/components/run_command.c
+++ b/components/run_command.c
@@ -1,4 +1,5 @@
 /* See LICENSE file for copyright and license details. */
+#include <errno.h>
 #include <stdio.h>
 #include <string.h>
 
@@ -12,7 +13,7 @@ run_command(const char *cmd)
 
        fp = popen(cmd, "r");
        if (fp == NULL) {
-               fprintf(stderr, "Failed to get command output for %s", cmd);
+               fprintf(stderr, "popen '%s': %s\n", cmd, strerror(errno));
                return NULL;
        }
        p = fgets(buf, sizeof(buf) - 1, fp);

diff --git a/components/swap.c b/components/swap.c
index b82ff46b492553539458e295c9b3eadb85591241..f3bbeb2337ea808943508fa7cfabaf5b5e40bb64 100644 (file)
--- a/components/swap.c
+++ b/components/swap.c
@@ -1,5 +1,6 @@
 /* See LICENSE file for copyright and license details. */
 #if defined(__linux__)
+#include <errno.h>
 #include <stdio.h>
 #include <string.h>
 
@@ -15,12 +16,12 @@ swap_free(void)
 
        fp = fopen("/proc/meminfo", "r");
        if (fp == NULL) {
-               fprintf(stderr, "Failed to open file /proc/meminfo");
+               fprintf(stderr, "fopen '/proc/meminfo': %s\n", strerror(errno));
                return NULL;
        }
 
        if ((bytes_read = fread(buf, sizeof(char), sizeof(buf) - 1, fp)) == 0) {
-               fprintf(stderr, "swap_free: read error");
+               fprintf(stderr, "fread '/proc/meminfo': %s\n", strerror(errno));
                fclose(fp);
                return NULL;
        }
@@ -47,12 +48,12 @@ swap_perc(void)
 
        fp = fopen("/proc/meminfo", "r");
        if (fp == NULL) {
-               fprintf(stderr, "Failed to open file /proc/meminfo");
+               fprintf(stderr, "fopen '/proc/meminfo': %s\n", strerror(errno));
                return NULL;
        }
 
        if ((bytes_read = fread(buf, sizeof(char), sizeof(buf) - 1, fp)) == 0) {
-               fprintf(stderr, "swap_perc: read error");
+               fprintf(stderr, "fread '/proc/meminfo': %s\n", strerror(errno));
                fclose(fp);
                return NULL;
        }
@@ -83,11 +84,11 @@ swap_total(void)
 
        fp = fopen("/proc/meminfo", "r");
        if (fp == NULL) {
-               fprintf(stderr, "Failed to open file /proc/meminfo");
+               fprintf(stderr, "fopen '/proc/meminfo': %s\n", strerror(errno));
                return NULL;
        }
        if ((bytes_read = fread(buf, sizeof(char), sizeof(buf) - 1, fp)) == 0) {
-               fprintf(stderr, "swap_total: read error");
+               fprintf(stderr, "fread '/proc/meminfo': %s\n", strerror(errno));
                fclose(fp);
                return NULL;
        }
@@ -110,11 +111,11 @@ swap_used(void)
 
        fp = fopen("/proc/meminfo", "r");
        if (fp == NULL) {
-               fprintf(stderr, "Failed to open file /proc/meminfo");
+               fprintf(stderr, "fopen '/proc/meminfo': %s\n", strerror(errno));
                return NULL;
        }
        if ((bytes_read = fread(buf, sizeof(char), sizeof(buf) - 1, fp)) == 0) {
-               fprintf(stderr, "swap_used: read error");
+               fprintf(stderr, "fread '/proc/meminfo': %s\n", strerror(errno));
                fclose(fp);
                return NULL;
        }

diff --git a/components/uptime.c b/components/uptime.c
index 8a04b92a22f17783eed5f2232e227549166b0a7f..a3082f28f133ec6c2006fb7e600464537874440a 100644 (file)
--- a/components/uptime.c
+++ b/components/uptime.c
@@ -1,5 +1,7 @@
 /* See LICENSE file for copyright and license details. */
+#include <errno.h>
 #include <stdio.h>
+#include <string.h>
 #if defined(__linux__)
 #include <sys/sysinfo.h>
 #elif defined(__OpenBSD__)
@@ -35,8 +37,10 @@ uptime(void)
 
        if (sysctl(mib, 2, &boottime, &size, NULL, 0) != -1)
                uptime = now - boottime.tv_sec;
-       else
+       else {
+               fprintf(stderr, "sysctl 'KERN_BOOTTIME': %s\n", strerror(errno));
                return NULL;
+       }
 #endif
        h = uptime / 3600;
        m = (uptime - h * 3600) / 60;

diff --git a/components/user.c b/components/user.c
index ffbd945b8b796b4d60c27c6d7af1a48ec2aff920..b335dc3e62fe2426fe197426362565a9d8405f8e 100644 (file)
--- a/components/user.c
+++ b/components/user.c
@@ -1,6 +1,8 @@
 /* See LICENSE file for copyright and license details. */
+#include <errno.h>
 #include <pwd.h>
 #include <stdio.h>
+#include <string.h>
 #include <sys/types.h>
 #include <unistd.h>
 
@@ -18,7 +20,7 @@ username(void)
        struct passwd *pw = getpwuid(geteuid());
 
        if (pw == NULL) {
-               fprintf(stderr, "Failed to get username");
+               fprintf(stderr, "getpwuid '%d': %s\n", geteuid(), strerror(errno));
                return NULL;
        }
 

diff --git a/components/volume.c b/components/volume.c
index ec653a234c35b0abd5297efee836b87e259c93a6..4c9a6ac4887df6dff50e744e939a814a6ccc94cf 100644 (file)
--- a/components/volume.c
+++ b/components/volume.c
@@ -1,5 +1,6 @@
 /* See LICENSE file for copyright and license details. */
 #if defined(__linux__)
+#include <errno.h>
 #include <fcntl.h>
 #include <sys/soundcard.h>
 #include <sys/ioctl.h>
@@ -18,19 +19,19 @@ vol_perc(const char *card)
 
        afd = open(card, O_RDONLY | O_NONBLOCK);
        if (afd == -1) {
-               fprintf(stderr, "Cannot open %s", card);
+               fprintf(stderr, "open '%s': %s\n", card, strerror(errno));
                return NULL;
        }
 
        if (ioctl(afd, SOUND_MIXER_READ_DEVMASK, &devmask) == -1) {
-               fprintf(stderr, "Cannot get volume for %s", card);
+               fprintf(stderr, "ioctl 'SOUND_MIXER_READ_DEVMASK': %s\n", strerror(errno));
                close(afd);
                return NULL;
        }
        for (i = 0; i < LEN(vnames); i++) {
                if (devmask & (1 << i) && !strcmp("vol", vnames[i])) {
                        if (ioctl(afd, MIXER_READ(i), &v) == -1) {
-                               fprintf(stderr, "vol_perc: ioctl");
+                               fprintf(stderr, "ioctl 'MIXER_READ(%d)': %s\n", i, strerror(errno));
                                close(afd);
                                return NULL;
                        }

diff --git a/components/wifi.c b/components/wifi.c
index 500332eb6070c25bfd67c7f32cae139963d1ef67..388a30d1a5fd6d98c2c476f82eefa02b53beb9a3 100644 (file)
--- a/components/wifi.c
+++ b/components/wifi.c
@@ -1,5 +1,6 @@
 /* See LICENSE file for copyright and license details. */
 #if defined(__linux__)
+#include <errno.h>
 #include <ifaddrs.h>
 #include <linux/wireless.h>
 #include <sys/socket.h>
@@ -25,7 +26,7 @@ wifi_perc(const char *iface)
        snprintf(path, sizeof(path), "%s%s%s", "/sys/class/net/", iface, "/operstate");
        fp = fopen(path, "r");
        if (fp == NULL) {
-               fprintf(stderr, "Failed to open file %s", path);
+               fprintf(stderr, "fopen '%s': %s\n", path, strerror(errno));
                return NULL;
        }
        p = fgets(status, 5, fp);
@@ -36,7 +37,7 @@ wifi_perc(const char *iface)
 
        fp = fopen("/proc/net/wireless", "r");
        if (fp == NULL) {
-               fprintf(stderr, "Failed to open file /proc/net/wireless");
+               fprintf(stderr, "fopen '/proc/net/wireless': %s\n", strerror(errno));
                return NULL;
        }
 
@@ -71,12 +72,12 @@ wifi_essid(const char *iface)
        snprintf(wreq.ifr_name, sizeof(wreq.ifr_name), "%s", iface);
 
        if (sockfd == -1) {
-               fprintf(stderr, "Failed to get ESSID for interface %s", iface);
+               fprintf(stderr, "socket 'AF_INET': %s\n", strerror(errno));
                return NULL;
        }
        wreq.u.essid.pointer = id;
        if (ioctl(sockfd,SIOCGIWESSID, &wreq) == -1) {
-               fprintf(stderr, "Failed to get ESSID for interface %s", iface);
+               fprintf(stderr, "ioctl 'SIOCGIWESSID': %s\n", strerror(errno));
                close(sockfd);
                return NULL;
        }

diff --git a/util.c b/util.c
index cd3524b2c4ed3df9c2317b5e97f1fe90ca06f226..6008ffc137c45813c83715cf3a683df876044138 100644 (file)
--- a/util.c
+++ b/util.c
@@ -1,4 +1,5 @@
 /* See LICENSE file for copyright and license details. */
+#include <errno.h>
 #include <stdarg.h>
 #include <stdio.h>
 #include <string.h>
@@ -29,7 +30,7 @@ pscanf(const char *path, const char *fmt, ...)
        int n;
 
        if (!(fp = fopen(path, "r"))) {
-               fprintf(stderr, "fopen for %s failed", path);
+               fprintf(stderr, "fopen '%s': %s\n", path, strerror(errno));
                return -1;
        }
        va_start(ap, fmt);