From: Hiltjo Posthuma <hiltjo@codemadness.org>
Date: Sun, 3 Jan 2016 20:15:13 +0000 (+0100)
Subject: refs: dont make a table when there are no tags, add spacing between
X-Git-Url: https://git.atheridis.org/?a=commitdiff_plain;h=465d72a6d2795bb42d5e688dcb82af5169973483;p=forks%2Fstagit.git

refs: dont make a table when there are no tags, add spacing between
---

diff --git a/stagit.c b/stagit.c
index 9d8efad..4b56829 100644
--- a/stagit.c
+++ b/stagit.c
@@ -881,17 +881,24 @@ writetags(FILE *fp)
 	const git_oid *id = NULL;
 	size_t i, len;
 
-	fputs("<h2>Tags</h2><table id=\"branches\"><thead>\n<tr><td>Tag</td>"
-	      "<td>Age</td><td>Commit message</td>"
-	      "<td>Author</td><td>Files</td><td class=\"num\">+</td>"
-	      "<td class=\"num\">-</td></tr>\n</thead><tbody>\n", fp);
-
 	/* summary page with branches and tags */
 	memset(&tagnames, 0, sizeof(tagnames));
-	git_tag_list(&tagnames, repo);
+	if (git_tag_list(&tagnames, repo))
+		return -1;
+	if (!tagnames.count) {
+		git_strarray_free(&tagnames);
+		return 0;
+	}
+
 	/* sort names */
 	qsort(tagnames.strings, tagnames.count, sizeof(char *),
 	      (int (*)(const void *, const void *))&tagcompare);
+
+	fputs("<h2>Tags</h2><table id=\"branches\"><thead>\n<tr><td>Tag</td>"
+	      "<td>Age</td><td>Commit message</td>"
+	      "<td>Author</td><td>Files</td><td class=\"num\">+</td>"
+	      "<td class=\"num\">-</td></tr>\n</thead><tbody>\n", fp);
+
 	for (i = 0; i < tagnames.count; i++) {
 		if (git_revparse_single(&obj, repo, tagnames.strings[i]))
 			continue;
@@ -946,6 +953,7 @@ writerefs(FILE *fp)
 
 	if ((ret = writebranches(fp)))
 		return ret;
+	fputs("<br/>", fp);
 	return writetags(fp);
 }