From: NRK <nrk@disroot.org>
Date: Thu, 14 Jul 2022 01:26:40 +0000 (+0600)
Subject: do not call signal-unsafe function inside sighanlder
X-Git-Url: https://git.atheridis.org/?a=commitdiff_plain;h=6613d9f9a1a5630bab30bc2b70bdc793977073ee;p=suckless%2Fdwm.git

do not call signal-unsafe function inside sighanlder

die() calls vprintf, fputc and exit; none of these are
async-signal-safe, see `man 7 signal-safety`.
---

diff --git a/dwm.c b/dwm.c
index b3c43ee..7c0f978 100644
--- a/dwm.c
+++ b/dwm.c
@@ -1541,6 +1541,8 @@ setup(void)
 	Atom utf8string;
 
 	/* clean up any zombies immediately */
+	if (signal(SIGCHLD, sigchld) == SIG_ERR)
+		die("can't install SIGCHLD handler:");
 	sigchld(0);
 
 	/* init screen */
@@ -1638,8 +1640,6 @@ showhide(Client *c)
 void
 sigchld(int unused)
 {
-	if (signal(SIGCHLD, sigchld) == SIG_ERR)
-		die("can't install SIGCHLD handler:");
 	while (0 < waitpid(-1, NULL, WNOHANG));
 }