From: Hiltjo Posthuma <hiltjo@codemadness.org>
Date: Fri, 22 Jul 2022 07:18:52 +0000 (+0200)
Subject: Revert "do not call signal-unsafe function inside sighanlder"
X-Git-Url: https://git.atheridis.org/?a=commitdiff_plain;h=e03248a4d5feaaacb130416be6e467a04de81f78;p=suckless%2Fdwm.git

Revert "do not call signal-unsafe function inside sighanlder"

This reverts commit 6613d9f9a1a5630bab30bc2b70bdc793977073ee.

Discussed on the mailinglist:
https://lists.suckless.org/hackers/2207/18405.html
---

diff --git a/dwm.c b/dwm.c
index 7c0f978..b3c43ee 100644
--- a/dwm.c
+++ b/dwm.c
@@ -1541,8 +1541,6 @@ setup(void)
 	Atom utf8string;
 
 	/* clean up any zombies immediately */
-	if (signal(SIGCHLD, sigchld) == SIG_ERR)
-		die("can't install SIGCHLD handler:");
 	sigchld(0);
 
 	/* init screen */
@@ -1640,6 +1638,8 @@ showhide(Client *c)
 void
 sigchld(int unused)
 {
+	if (signal(SIGCHLD, sigchld) == SIG_ERR)
+		die("can't install SIGCHLD handler:");
 	while (0 < waitpid(-1, NULL, WNOHANG));
 }