From: Hiltjo Posthuma <hiltjo@codemadness.org>
Date: Sun, 16 Apr 2017 18:59:23 +0000 (+0200)
Subject: writeblobhtml: fix possible uninitialized variable n when len == 0
X-Git-Url: https://git.atheridis.org/?a=commitdiff_plain;h=f9e7dc80702317cf5b9c764eeec89e2cbde8c982;p=forks%2Fstagit.git

writeblobhtml: fix possible uninitialized variable n when len == 0

... whoops
---

diff --git a/stagit.c b/stagit.c
index 09f3df7..f438a02 100644
--- a/stagit.c
+++ b/stagit.c
@@ -378,7 +378,7 @@ writefooter(FILE *fp)
 int
 writeblobhtml(FILE *fp, const git_blob *blob)
 {
-	size_t n, i, prev;
+	size_t n = 0, i, prev;
 	const char *nfmt = "<a href=\"#l%d\" class=\"line\" id=\"l%d\">%6d</a> ";
 	const char *s = git_blob_rawcontent(blob);
 	git_off_t len = git_blob_rawsize(blob);
@@ -386,7 +386,7 @@ writeblobhtml(FILE *fp, const git_blob *blob)
 	fputs("<pre id=\"blob\">\n", fp);
 
 	if (len > 0) {
-		for (i = 0, prev = 0, n = 0; i < (size_t)len; i++) {
+		for (i = 0, prev = 0; i < (size_t)len; i++) {
 			if (s[i] != '\n')
 				continue;
 			n++;